Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc: addressmap: Add ERC55 address validity check #2607

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

prasannavl
Copy link
Member

Summary

  • Check that ERC55 addresses are a part of the wallet before displaying them.
  • The error message will still include the mapped key for reference.
  • Just makes the intent clearer avoiding confusion and more intuitive UX.

Ref: #2604
Based on: #2605

Example error:

$ defi-cli addressmap df1qxy7pme86lmnhwrsfvqwjy2tftrvkk2l0y4mznu 1
error code: -5
error message:
no valid public key for address 0x0e634a60cC95437DE0836fD1E91A7144965Fd821

Implications

  • Storage

    • Database reindex required
    • Database reindex optional
    • Database reindex not required
    • None
  • Consensus

    • Network upgrade required
    • Includes backward compatible changes
    • Includes consensus workarounds
    • Includes consensus refactors
    • None

@Bushstar Bushstar merged commit 8597e7d into master Oct 23, 2023
11 of 13 checks passed
@Bushstar Bushstar deleted the pvl/addr-erc55-check branch October 23, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants